Skip to content

RLM env stop condition fix #757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
snimu merged 2 commits into from
Jan 22, 2026
Merged

RLM env stop condition fix #757

snimu merged 2 commits into from
Jan 22, 2026
+7 −0

Conversation

@eligotts
Copy link
Contributor

@eligotts eligotts commented Jan 21, 2026 •
edited by cursor bot
Loading

Description

Previously, there would be an extra model call even after the model set answer="Ready"

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Test improvement

Testing

  • All existing tests pass when running uv run pytest locally.
  • New tests have been added to cover the changes

Checklist

  • My code follows the style guidelines of this project as outlined in AGENTS.md
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

Additional Notes

Note

Optimizes the RLM environment to stop immediately once the answer is ready, avoiding an extra LLM call.

  • Adds env_response override to set state["final_env_response"] when final_answer exists, ensuring the final tool messages are captured and halting further calls
  • No other behavioral changes; existing stop conditions and rendering logic remain intact

Written by Cursor Bugbot for commit 4a47b84. This will update automatically on new commits. Configure here.

@CLAassistant
Copy link

CLAassistant commented Jan 21, 2026 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

snimu
snimu requested changes Jan 22, 2026
View reviewed changes
Copy link
Contributor

@snimu snimu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great with both Bash and Python, just needs a small fix to be fully correct

@snimu snimu merged commit 6c6c139 into PrimeIntellect-ai:main Jan 22, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@snimu snimu snimu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eligotts @CLAassistant @snimu